[webkit-reviews] review denied: [Bug 48493] Rendered <noscript> tag if XHTMLMP feature is enable. : [Attachment 72783] If XHTMLMP is enabled, class "document" has an additional member, m_shouldProcessNoScriptElement. I use this to determine if noscript should be rendered or not.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 2 18:58:06 PDT 2010


Adam Barth <abarth at webkit.org> has denied kyounga <kyounga.ra at gmail.com>'s
request for review:
Bug 48493: Rendered <noscript> tag if XHTMLMP feature is enable.
https://bugs.webkit.org/show_bug.cgi?id=48493

Attachment 72783: If XHTMLMP is enabled, class "document" has an additional
member, m_shouldProcessNoScriptElement. I use this to determine if noscript
should be rendered or not.
https://bugs.webkit.org/attachment.cgi?id=72783&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72783&action=review

We need a ChangeLog and a test.

> WebCore/html/HTMLElement.cpp:784
> +	   if (!document()->shouldProcessNoscriptElement())

What is this bit?  How is it computed?


More information about the webkit-reviews mailing list