[webkit-reviews] review granted: [Bug 48878] NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc. : [Attachment 72751] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 48878: NRWT doesn't have good test coverage for --run-chunk, --batch-size,
--run-part, etc.
https://bugs.webkit.org/show_bug.cgi?id=48878

Attachment 72751: Patch
https://bugs.webkit.org/attachment.cgi?id=72751&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72751&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:109
> +def get_tests_run(args=[], tests_included=False, flatten_batches=False):

Nit: The use of args=[] as a default arg is correct in this case only because
we never modify args in the function.  I would just remove the default value so
it doesn't trip someone up in the future.