[webkit-reviews] review requested: [Bug 27048] [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects : [Attachment 72774] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 2 17:10:37 PDT 2010


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 27048: [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding
events for text objects
https://bugs.webkit.org/show_bug.cgi?id=27048

Attachment 72774: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=72774&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #2)
> [...]
> Hope this helps. Let me know if you have questions. Thanks!

Really, really helpful... so much helpful that I'm now attaching a patch and
asking for review over it :-). At the end I had to write a GTK-specific
solution because it seems WebCore does not support focusing on text objects, so
it's not as much a general solution as I'd have liked... but it works great
with Accerciser, so I think it's worth it to propose it for review at this
point.

Thanks Joanie!


More information about the webkit-reviews mailing list