[webkit-reviews] review granted: [Bug 48882] Add support for NP_HasMethod and NP_Invoke : [Attachment 72757] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 2 16:06:57 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48882: Add support for NP_HasMethod and NP_Invoke
https://bugs.webkit.org/show_bug.cgi?id=48882
Attachment 72757: Patch
https://bugs.webkit.org/attachment.cgi?id=72757&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72757&action=review
> WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:82
> + Vector<NPVariant> arguments;
> + for (size_t i = 0; i < argumentsData.size(); ++i)
> +
arguments.append(m_npRemoteObjectMap->npVariantDataToNPVariant(argumentsData[i]
));
Don't we need to release these NPVariants, too?
More information about the webkit-reviews
mailing list