[webkit-reviews] review granted: [Bug 48850] [chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option : [Attachment 72701] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 2 15:43:08 PDT 2010
James Robinson <jamesr at chromium.org> has granted Vincent Scheib
<scheib at chromium.org>'s request for review:
Bug 48850: [chromium] GraphicsContext3D creation attributes include
canRecoverFromContextLoss option
https://bugs.webkit.org/show_bug.cgi?id=48850
Attachment 72701: Patch
https://bugs.webkit.org/attachment.cgi?id=72701&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72701&action=review
Looks good. Nit on a comment.
> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:55
> + attr.canRecoverFromContextLoss = false; // canvas contexts can not
handle lost contexts
Leading caps, trailing period.
More information about the webkit-reviews
mailing list