[webkit-reviews] review denied: [Bug 48768] Transferred <iframe>s may not have a unique internal name : [Attachment 72739] update internal frame name on reparenting

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 48768: Transferred <iframe>s may not have a unique internal name
https://bugs.webkit.org/show_bug.cgi?id=48768

Attachment 72739: update internal frame name on reparenting
https://bugs.webkit.org/attachment.cgi?id=72739&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72739&action=review

I have a work in progress patch for this issue and was planned to address it
after I land bug #6751.

> WebCore/page/Frame.cpp:738
> +	       tree()->setName(tree()->name());

Because of <https://bugs.webkit.org/show_bug.cgi?id=48806#c0> we can't call
setName() after appendChild() since the child count will be off. Disregarding
the frame prefix, notice in your results the unique name has <!--frame2-->, but
we count from zero, so this should be <!--frame1-->.