[webkit-reviews] review granted: [Bug 48212] SVG FELighting performance issues : [Attachment 72664] final patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 48212: SVG FELighting performance issues
https://bugs.webkit.org/show_bug.cgi?id=48212

Attachment 72664: final patch
https://bugs.webkit.org/attachment.cgi?id=72664&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72664&action=review

r=me with little style changes.

> WebCore/platform/graphics/filters/FELighting.cpp:178
> +inline void FELighting::inlineSetPixel(int offset, LightingData& data,
LightSource::PaintingData& paintingData,
> +    int lightX, int lightY, float factorX, float factorY, IntPoint&
normal2DVector)

align the int's

> WebCore/platform/graphics/filters/FELighting.cpp:227
> +void FELighting::setPixel(int offset, LightingData& data,
LightSource::PaintingData& paintingData,
> +    int lightX, int lightY, float factorX, float factorY, IntPoint&
normalVector)

align the int's.

> WebCore/platform/graphics/filters/FELighting.h:76
> +    inline void inlineSetPixel(int offset, LightingData&,
LightSource::PaintingData&,
> +	   int lightX, int lightY, float factorX, float factorY, IntPoint&
normalVector);

please align the ints

> WebCore/platform/graphics/filters/FELighting.h:80
> +    void setPixel(int offset, LightingData&, LightSource::PaintingData&,
> +	   int lightX, int lightY, float factorX, float factorY, IntPoint&
normalVector);

Ditto.