[webkit-reviews] review granted: [Bug 48864] Add some support for remote and local NPObjects to NPRemoteObjectMap : [Attachment 72724] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48864: Add some support for remote and local NPObjects to NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48864

Attachment 72724: Patch
https://bugs.webkit.org/attachment.cgi?id=72724&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72724&action=review

> WebKit2/Shared/Plugins/NPVariantData.cpp:109
> +    // We special case LocalNPObjectID and RemoteNPObjectID here so a
LocalNPObjectID is
> +    // encoded as a RemoteNPObjectID and vice versa.

Should be "special-case" and "decoded", not "special case" and "encoded". Maybe
you could explain a little more, saying that the encoded type is from the
perspective of the other process, so we have to adjust it to match our own
perspective?