[webkit-reviews] review granted: [Bug 46579] Reproducible crash in appcache code when closing pgatour.com : [Attachment 72714] patch - reorder calls in FrameLoader::detachFromParent()

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 46579: Reproducible crash in appcache code when closing pgatour.com
https://bugs.webkit.org/show_bug.cgi?id=46579

Attachment 72714: patch - reorder calls in FrameLoader::detachFromParent()
https://bugs.webkit.org/attachment.cgi?id=72714&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72714&action=review

Looks great, thanks for getting to the bottom of this!

You can consider also landing my test - it's different in that it closes top
frame, not an intermediate one.

>
LayoutTests/http/tests/navigation/resources/image-load-in-subframe-unload-handl
er-helper.html:9
> +	   var img = new Image(1, 1);
> +	   // We're using a redirect here because it guarantees that if we're
> +	   // receiving callbacks in a detached Frame, we'll acceess members
> +	   // that are now invalid (e.g., DocumentLoaders).
> +	   img.src = "redirect302.pl";

Maybe append the image to body, to make sure the test doesn't rely on whether
detached images are loaded?