[webkit-reviews] review denied: [Bug 48674] blendFunc should generate INVALID_OPERATION if constant color and constant alpha are together as source and destination factors : [Attachment 72595] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 48674: blendFunc should generate INVALID_OPERATION if constant color and
constant alpha are together as source and destination factors
https://bugs.webkit.org/show_bug.cgi?id=48674

Attachment 72595: patch
https://bugs.webkit.org/attachment.cgi?id=72595&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72595&action=review

> WebCore/html/canvas/WebGLRenderingContext.cpp:372
> +	       && (srcRGB == GraphicsContext3D::CONSTANT_ALPHA || srcRGB ==
GraphicsContext3D::ONE_MINUS_CONSTANT_ALPHA))) {

Please factor out this logic into a helper function or method and call it from
both blendFunc and blendFuncSeparate.