[webkit-reviews] review denied: [Bug 46318] Perform framebuffer attachment checking upon draw call rather than attachment : [Attachment 72252] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied  review:
Bug 46318: Perform framebuffer attachment checking upon draw call rather than
attachment
https://bugs.webkit.org/show_bug.cgi?id=46318

Attachment 72252: patch
https://bugs.webkit.org/attachment.cgi?id=72252&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72252&action=review

Sorry, I noticed an issue after r+'ing the patch. Hopefully you get this email
before landing.

> WebCore/html/canvas/WebGLRenderingContext.cpp:458
> +	   return GraphicsContext3D::FRAMEBUFFER_INCOMPLETE_ATTACHMENT;

According to the spec this is supposed to be FRAMEBUFFER_UNSUPPORTED. Is there
a reason to diverge? If not, please update the code and the test.