[webkit-reviews] review granted: [Bug 46318] Perform framebuffer attachment checking upon draw call rather than attachment : [Attachment 72252] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 46318: Perform framebuffer attachment checking upon draw call rather than
attachment
https://bugs.webkit.org/show_bug.cgi?id=46318

Attachment 72252: patch
https://bugs.webkit.org/attachment.cgi?id=72252&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72252&action=review

Looks good overall. Couple of minor comments.

> WebCore/html/canvas/WebGLFramebuffer.cpp:38
> +static unsigned long getInternalFormat(WebGLObject* buffer)

You could use an anonymous namespace instead of static methods here.

> WebCore/html/canvas/WebGLFramebuffer.cpp:141
> +	   return true;

This test seems redundant.

> WebCore/html/canvas/WebGLFramebuffer.h:49
> +    // readPixels, copyTexImage2D, copyTexSubImage2D if this frame bufferis

bufferis -> buffer is