[webkit-reviews] review granted: [Bug 48839] Web Inspector: display frame names in the resources panel. : [Attachment 72673] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 48839: Web Inspector: display frame names in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48839

Attachment 72673: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=72673&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72673&action=review

> WebCore/inspector/front-end/ResourceManager.js:487
> +	   var tmpResource = new WebInspector.Resource(null, frame.url);

Would be better just to factor out displayName so you don't need to make a
Resource.

> WebCore/inspector/front-end/StoragePanel.js:863
> +		   subtitleElement.textContent = "(" + subtitle + ")";

Why the ()? Screenshot?