[webkit-reviews] review granted: [Bug 48847] More NPRuntime work : [Attachment 72694] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48847: More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=48847

Attachment 72694: Patch
https://bugs.webkit.org/attachment.cgi?id=72694&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72694&action=review

> WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:54
>  NPObjectMessageReceiver::~NPObjectMessageReceiver()
>  {
> +    m_npRemoteObjectMap->unregisterNPObject(m_npObjectID);
> +

What guarantees the map hasn't been destroyed by this point?

> WebKit2/Shared/Plugins/NPVariantData.cpp:46
> +NPVariantData NPVariantData::makeVoid()
>  {
> -    notImplemented();
> -    return false;
> +    NPVariantData npVariantData;
> +
> +    return npVariantData;
> +}

How about: return NPVariantData();