[webkit-reviews] review requested: [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers : [Attachment 72658] Fix and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 2 06:45:15 PDT 2010


Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 48110: getBoundingClientRect: Do not truncate the coordinates to integers
https://bugs.webkit.org/show_bug.cgi?id=48110

Attachment 72658: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=72658&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
(In reply to comment #8)
> > WebCore/rendering/RenderObject.h:1006
> > +inline float adjustFloatForAbsoluteZoom(float value, RenderObject*
renderer)
> > [snip]
>
> This helper function seems useless.

I agree. I just followed the pattern used in
adjustForAbsoluteZoom(int,RenderObject*).
So I assume you consider adjustForAbsoluteZoom equally useless, and all the
calls from dom/Element.cpp and html/HTMLImageElement.cpp should be directed to
adjustForAbsoluteZoom(int,RenderStyle*)?
(I'm only asking; I am by no means suggesting that I should do that here...)


More information about the webkit-reviews mailing list