[webkit-reviews] review granted: [Bug 48425] Clean up IDBTransactionBackend/Coordinator : [Attachment 72041] a

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 2 06:15:58 PDT 2010


Steve Block <steveblock at google.com> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 48425: Clean up IDBTransactionBackend/Coordinator
https://bugs.webkit.org/show_bug.cgi?id=48425

Attachment 72041: a
https://bugs.webkit.org/attachment.cgi?id=72041&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72041&action=review

>>> WebCore/storage/IDBTransactionCoordinator.h:63
>>> +	 HashMap<IDBTransactionBackendImpl*, RefPtr<IDBTransactionBackendImpl>
> m_transactions;
>> 
>> Using a map like this seems a little odd. Can't you just use a HashSet? If
required, you could provide a custom HashFunctions to make sure the value of
the raw pointer is used when looking up a value.
> 
> I'm pretty sure I'd have to create some custom version that handles the keys
being ref pointers.  Is it really worth the effort to do this?	Does it really
make it that much more clean?  Maybe just a fixme is enough so the tradeoff is
documented?

Sure, I guess a FIXME is OK. I think it's worth a quick try though - I didn't
read through all of HashSet, but I think it might just work with RefPtr.


More information about the webkit-reviews mailing list