[webkit-reviews] review denied: [Bug 48817] Chromium: Propagate a document value changed notification on scroll. : [Attachment 72621] Proposed patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 48817: Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

Attachment 72621: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=72621&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72621&action=review

looks ok otherwise.

> WebCore/accessibility/chromium/AXObjectCacheChromium.cpp:52
> +    if (obj->roleValue() == ScrollBarRole && notification == AXValueChanged)
{

i don't think obj->roleValue() is a strong enough check for doing a
static_cast. If not already, I can see something like <div role="scrollbar"> in
the future.

You should add a method to AccessibilityScrollbar that says
"isNativeScrollbar()" or something to that effect, that will allow you to
safely cast.