[webkit-reviews] review denied: [Bug 29363] Support for <output> element : [Attachment 72626] Patch V2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 29363: Support for <output> element
https://bugs.webkit.org/show_bug.cgi?id=29363

Attachment 72626: Patch V2
https://bugs.webkit.org/attachment.cgi?id=72626&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72626&action=review

>
LayoutTests/fast/dom/HTMLOutputElement/htmloutputelement-validity-expected.txt:
1
> +CONSOLE MESSAGE: line 25: true

Something wrong.

> WebCore/html/HTMLOutputElement.h:44
> +    virtual bool isEnumeratable() const { return true; }

Need a test for this.
However, I couldn't find existing tests for from control enumeration.  We might
need a new test for all of form control types.

These override functions (isEnumeratable, willValidate, reset, childrenChanged)
should be moved to private:.