[webkit-reviews] review granted: [Bug 48798] Add RealtimeAnalyserNode files : [Attachment 72589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 19:01:38 PDT 2010


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 48798: Add RealtimeAnalyserNode files
https://bugs.webkit.org/show_bug.cgi?id=48798

Attachment 72589: Patch
https://bugs.webkit.org/attachment.cgi?id=72589&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine. The hardcoded fetches of input and output 0 in process() and
pullInputs() are a little subtle, but I see that they make sense because this
node is defined as having one output and one input. Since all of the associated
code is self-contained in the .cpp, I don't think it's worth asking for
assertions about this fact.


More information about the webkit-reviews mailing list