[webkit-reviews] review granted: [Bug 47941] Add ConvolverNode files : [Attachment 71214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 18:47:05 PDT 2010


Kenneth Russell <kbr at google.com> has granted  review:
Bug 47941: Add ConvolverNode files
https://bugs.webkit.org/show_bug.cgi?id=47941

Attachment 71214: Patch
https://bugs.webkit.org/attachment.cgi?id=71214&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
After looking back through some of the other node implementations and noting
that they do not have assertions about process() being called on the audio
thread, I'm changing this to r+. My comment about the pointer to the AudioBus
temporary variable still stands, though.


More information about the webkit-reviews mailing list