[webkit-reviews] review granted: [Bug 48797] Respond to NP_GetProperty by sending a GetProperty message : [Attachment 72593] Patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48797: Respond to NP_GetProperty by sending a GetProperty message
https://bugs.webkit.org/show_bug.cgi?id=48797

Attachment 72593: Patch
https://bugs.webkit.org/attachment.cgi?id=72593&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72593&action=review

> WebKit2/Shared/Plugins/NPObjectProxy.cpp:40
> +NPObjectProxy* NPObjectProxy::create(NPRemoteObjectMap* npRemoteObjectMap,
uint64_t npObjectID)

Is it legal to pass 0 for the npRemoteObjectMap?

> WebKit2/Shared/Plugins/NPObjectProxy.cpp:80
> +	   return false;

Should this nil-check m_npRemoteObjectMap?

> WebKit2/WebKit2.xcodeproj/project.pbxproj:2613
>		};

Do you need to update the Visual Studio project file also?