[webkit-reviews] review granted: [Bug 48794] new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests : [Attachment 72579] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 16:11:28 PDT 2010


Ojan Vafai <ojan at chromium.org> has granted kalman at chromium.org's request for
review:
Bug 48794: new-run-webkit-tests doesn't strip "LayoutTests/" from prefix,
unlike old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=48794

Attachment 72579: Patch
https://bugs.webkit.org/attachment.cgi?id=72579&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72579&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:293
> +	   test_dir = 'LayoutTests/'

As discussed in person, lets make this a constant and use os.sep.


More information about the webkit-reviews mailing list