[webkit-reviews] review requested: [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images. : [Attachment 72577] Add new method shouldPaintBrokenImageWithError for FrameLoaderClient;

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 15:46:38 PDT 2010


Yongjun Zhang <yongjun_zhang at apple.com> has asked  for review:
Bug 48781: Add a resourceload delegate method to query if WebCore should paint
the default broken image for failed images.
https://bugs.webkit.org/show_bug.cgi?id=48781

Attachment 72577: Add new method shouldPaintBrokenImageWithError for
FrameLoaderClient;
https://bugs.webkit.org/attachment.cgi?id=72577&action=review

------- Additional Comments from Yongjun Zhang <yongjun_zhang at apple.com>
The patch implements shouldPaintBrokenImageWithError for mac, for other ports,
it just makes a empty implementation.

I am not sure if it is the best way to add error code enums in CachedImage.h, I
can move the error codes to a dedicated header file is that is preferred.


More information about the webkit-reviews mailing list