[webkit-reviews] review granted: [Bug 48785] Setting attr repeatDur=0 on SVG element causes hang : [Attachment 72563] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 48785: Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785

Attachment 72563: Patch
https://bugs.webkit.org/attachment.cgi?id=72563&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72563&action=review

> WebCore/svg/animation/SVGSMILElement.cpp:531
> -    return m_cachedRepeatDur = clockValue < 0 ? SMILTime::unresolved() :
clockValue;
> +    return m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() :
clockValue;

The assignment in the return statement is pretty grody here. Please change to:

m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() : clockValue;
return m_cachedRepeatDur;

> LayoutTests/svg/animations/repeatDur-zero.xhtml:10
> +</svg>
>  \ No newline at end of file

Please add the newline.