[webkit-reviews] review granted: [Bug 48784] Teach check-webkit-style how to accept a list of files to diff on the command line : [Attachment 72561] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 48784: Teach check-webkit-style how to accept a list of files to diff on
the command line
https://bugs.webkit.org/show_bug.cgi?id=48784

Attachment 72561: Patch
https://bugs.webkit.org/attachment.cgi?id=72561&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72561&action=review

Looks sane otherwise.  I believe your understanding of python's None argument
convention is mistaken.  I feel like we have this argument often. :)

> WebKitTools/Scripts/check-webkit-style:118
> +	   changed_files = paths if options.diff_files else []

I think you want else None here.  [] seems wrong.

> WebKitTools/Scripts/webkitpy/style_references.py:72
> +    def create_patch(self, git_commit, changed_files=[]):

You want None here. :)