[webkit-reviews] review canceled: [Bug 48719] HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40% : [Attachment 72488] work in progress, closes the gap to 2x as slow instead of 7x or 10x

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 48719: HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

Attachment 72488: work in progress, closes the gap to 2x as slow instead of 7x
or 10x
https://bugs.webkit.org/attachment.cgi?id=72488&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72488&action=review

The scary thing with this approach is if document has other state.  Maybe look
at all the insertedIntoDocument calls?

> WebCore/html/parser/HTMLTreeBuilder.cpp:421
> +    s_sharedDummyDocument->setURL(baseURL);

I'm not sure this is quite the right thing.  We might need to add a setBaseURL.