[webkit-reviews] review granted: [Bug 48693] Add idl and mock classes for FileWriterSync. : [Attachment 72423] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 48693: Add idl and mock classes for FileWriterSync.
https://bugs.webkit.org/show_bug.cgi?id=48693

Attachment 72423: Patch
https://bugs.webkit.org/attachment.cgi?id=72423&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review

> WebCore/ChangeLog:19
> +	   * bindings/scripts/CodeGeneratorV8.pm:

And android's build file?

So many build files....

> WebCore/fileapi/FileWriterSync.h:54
> +    void write(Blob* data, ExceptionCode& ec);

No need for param name "ec".

> WebCore/fileapi/FileWriterSync.h:55
> +    void seek(long long position, ExceptionCode& ec);

Ditto.

> WebCore/fileapi/FileWriterSync.h:56
> +    void truncate(long long length, ExceptionCode& ec);

Ditto.

> WebCore/fileapi/FileWriterSync.h:73
> +    friend class WTF::RefCounted<FileWriterSync>;

I believe that WTF:: is unnecessary.