[webkit-reviews] review granted: [Bug 48145] LayoutTests/fast/events/spatial-navigation/snav-multiple-select.html fails : [Attachment 72502] fix patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 48145: LayoutTests/fast/events/spatial-navigation/snav-multiple-select.html
fails
https://bugs.webkit.org/show_bug.cgi?id=48145

Attachment 72502: fix patch
https://bugs.webkit.org/attachment.cgi?id=72502&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72502&action=review

Thanks for fixing this!

> WebCore/dom/SelectElement.cpp:768
> +		   if (keyIdentifier == "Left" || keyIdentifier == "Right"||
((keyIdentifier == "Down" || keyIdentifier == "Up") && endIndex ==
data.activeSelectionEndIndex()))

Maybe we could have a helper method for this part

(keyIdentifier == "Down" || keyIdentifier == "Up") && endIndex ==
data.activeSelectionEndIndex()

just to make it clear what is going on?