[webkit-reviews] review denied: [Bug 48497] Avoid overlapping label text in autofill popup with icon : [Attachment 72274] Patch, addressing Jay's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 05:46:57 PDT 2010


Kent Tamura <tkent at chromium.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 48497: Avoid overlapping label text in autofill popup with icon
https://bugs.webkit.org/show_bug.cgi?id=48497

Attachment 72274: Patch, addressing Jay's comments
https://bugs.webkit.org/attachment.cgi?id=72274&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72274&action=review

> WebCore/ChangeLog:741
> +2010-10-27  Ilya Sherman  <isherman at chromium.org>

New ChangeLog entry should be at the beginning of the file.

> WebCore/platform/chromium/PopupMenuChromium.cpp:1278
> +		   width += kLabelToIconPadding;

We don't use "k" prefix in WebKit style.
I understand this symbol is not introduced by this patch.  So you don't need to
address this issue for now.


More information about the webkit-reviews mailing list