[webkit-reviews] review denied: [Bug 39749] webkit-patch fails to create bugs since it started assigning the owner : [Attachment 57510] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 31 22:49:14 PDT 2010
Eric Seidel <eric at webkit.org> has denied Lucas De Marchi
<lucas.demarchi at profusion.mobi>'s request for review:
Bug 39749: webkit-patch fails to create bugs since it started assigning the
owner
https://bugs.webkit.org/show_bug.cgi?id=39749
Attachment 57510: Patch
https://bugs.webkit.org/attachment.cgi?id=57510&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I would have broken this out into a separate function at this point.
+ log('User does not have editbugs privilege. It is not possible to
assign bug to %s' % assignee)
should be:
+ log('%s does not have editbugs privilege. It is not possible to
assign bug to %s' % (self.username, assignee))
Should also probably direct them to how to request the privilege (I'm not sure
how, for now we should ask them to email webkit-dev I guess).
Also this current patch will log about the "None" assignee which is not what
you mean to do.
More information about the webkit-reviews
mailing list