[webkit-reviews] review granted: [Bug 39958] [Qt] TextBreakIteratorQt performance : [Attachment 57508] Fixed based on Kenneth's latest comments.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted David Leong
<david.leong at nokia.com>'s request for review:
Bug 39958: [Qt] TextBreakIteratorQt performance
https://bugs.webkit.org/show_bug.cgi?id=39958

Attachment 57508: Fixed based on Kenneth's latest comments.
https://bugs.webkit.org/attachment.cgi?id=57508&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
I would personally have used previousString and not previousstring, as it fits
with how we normally name variables, but that is a nit. I'm r+, but please let
this sit for at least a day so that others have the change to have a look at it
as well.

WebCore/ChangeLog:5
 +	    [Qt] TextBreakIterator QT performance
It is called Qt, not QT. QT is short for QuickTime, which can cause confusion
as it is used other places in WebKit.

Did you measure if the inlining made any difference?