[webkit-reviews] review requested: [Bug 39854] Refactor platform dependent editing behavior code out of Settings : [Attachment 57502] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 31 17:49:00 PDT 2010


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 39854: Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854

Attachment 57502: patch v2
https://bugs.webkit.org/attachment.cgi?id=57502&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Same patch as patch 57495 (see comment #23 for a summary), but includes a fix
for Chromium-linux build (in comment #25) and style nit in comment #24.

As for the Mac build, I can not see the error log, and it gets hard to fix, but
I will fix at office tomorrow.

Apart from that, patch is ready for review.


More information about the webkit-reviews mailing list