[webkit-reviews] review denied: [Bug 39958] [Qt] TextBreakIterator QT performance : [Attachment 57499] Proposed fixes to TextBreakIteratorQt

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied David Leong
<david.leong at nokia.com>'s request for review:
Bug 39958: [Qt] TextBreakIterator QT performance
https://bugs.webkit.org/show_bug.cgi?id=39958

Attachment 57499: Proposed fixes to TextBreakIteratorQt
https://bugs.webkit.org/attachment.cgi?id=57499&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebCore/platform/text/qt/TextBreakIteratorQt.cpp:40
 +	static const UChar* tempBuf;
write out the names, 'buffer

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:41
 +	static int tempLen;
length

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:50
 +		tempBuf=0;
you need space between tempBuf and the 0

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:51
 +		tempLen=-1;
same here

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:52
 +		type=QTextBoundaryFinder::Word;
and here

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:54
 +	    if( tempBuf == string && tempLen == length && type ==
QTextBoundaryFinder::Word ) {
space after the if and no space before the tempBuf, same at the end

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:60
 +		tempBuf=string;
same

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:61
 +		tempLen=length;
same

WebCore/platform/text/qt/TextBreakIteratorQt.cpp:62
 +		type=QTextBoundaryFinder::Word;
same

Apart form this the code seems quite similar, maybe it makes sense creating an
inline method instead (using a template)?