[webkit-reviews] review requested: [Bug 39854] Refactor platform dependent editing behavior code out of Settings : [Attachment 57495] patch v1 - functional

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 39854: Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854

Attachment 57495: patch v1 - functional
https://bugs.webkit.org/attachment.cgi?id=57495&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
* Addresses Darin's previously requests for feedback{1,2,3,4}

Summary:

* EditingBehavior enum renamed to EditingBehaviorTypes and move out to
editing/EditingBehaviorTypes.h
- Also done with changes needed in WebKit/ due to the enum change.

* EditingBehavior class added. It is not to be directly instantiated, but
rather accessed via Editor::behavior() getter.
- Settings class will only know about the EditingBehaviorTypes enum, not about
EditingBehavior class
- EditingBehavior will only know about the EditingBehaviorTypes enum, not about
Settings or Editor.

* All existing Settings::defaultBehavior() == Editing{Mac,Windows}Behavior
changed to call methods in EditingBehavior class - (please review the methods
names, I am open to suggestions).
* Added new files to the build various sytems (hope I did not miss any).