[webkit-reviews] review denied: [Bug 39962] Remove hand-rolled JSC bindings for CanvasRenderingContext2D : [Attachment 57479] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 39962: Remove hand-rolled JSC bindings for CanvasRenderingContext2D
https://bugs.webkit.org/show_bug.cgi?id=39962

Attachment 57479: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=57479&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Great change!

> +	   No new tests as there is no new functionality.

Are there tests for each of these overload cases? If not, then I think we do
need tests, even though these code paths are not new. It looks to me like some
of these hand-written bindings have different handling for things like too many
arguments. It would be straightforward to write some tests that cover all these
cases, and I'd like to see that to provde that the hand-rolled code did not
behave any differently.