[webkit-reviews] review canceled: [Bug 30567] add support for exporting HTTP Archive format in Resources panel : [Attachment 57474] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 30567: add support for exporting HTTP Archive format in Resources panel
https://bugs.webkit.org/show_bug.cgi?id=30567

Attachment 57474: patch
https://bugs.webkit.org/attachment.cgi?id=57474&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
1. I would convert it to a prototype-based object with following usage: new
WebInspector.HAREntry(resource).build();
2. I'd also like to see a test for it.

WebCore/inspector/front-end/Resource.js:90
 +	    delete this._queryParameters;
Consider renaming to this._parsedQueryParameters

WebCore/inspector/front-end/Resource.js:395
 +	    return WebInspector.Resource.headerValue(this.requestHeaders,
headerName);
consider making private instance method

WebCore/inspector/front-end/Resource.js:406
 +	    delete this._formParameters;
this._parsedFormParameters

WebCore/inspector/front-end/Resource.js:452
 +	    return this._queryParameters =
WebInspector.Resource.parseParameters(queryString);
Also private instance method.