[webkit-reviews] review granted: [Bug 38842] [GStreamer] float variables misused : [Attachment 57263] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 31 08:50:21 PDT 2010


Xan Lopez <xan.lopez at gmail.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 38842: [GStreamer] float variables misused
https://bugs.webkit.org/show_bug.cgi?id=38842

Attachment 57263: proposed patch
https://bugs.webkit.org/attachment.cgi?id=57263&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
-    GstClockTime sec = (GstClockTime)(time * GST_SECOND);
+    GstClockTime sec = (GstClockTime)(time * static_cast<float>(GST_SECOND));

You forgot this, please fix when landing.


More information about the webkit-reviews mailing list