[webkit-reviews] review granted: [Bug 39833] Web Inspector: Implement retrieval of CSS stylesheets for source editing : [Attachment 57458] [PATCH] Altered patch as discussed offline with pfeldman

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 31 07:55:35 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 39833: Web Inspector: Implement retrieval of CSS stylesheets for source
editing
https://bugs.webkit.org/show_bug.cgi?id=39833

Attachment 57458: [PATCH] Altered patch as discussed offline with pfeldman
https://bugs.webkit.org/attachment.cgi?id=57458&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/css/CSSParser.cpp:234
 +  void CSSParser::parseSheet(CSSStyleSheet* sheet, const String& string,
HashMap<CSSStyleRule*, std::pair<unsigned, unsigned> >* ruleRangeMap)
You might want to introduce a typedef for this. Something like
StyleRulePositions.


More information about the webkit-reviews mailing list