[webkit-reviews] review requested: [Bug 39145] Add v8 bindings for async DB API in workers : [Attachment 57443] patch: fix the world context

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 31 02:23:13 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 39145: Add v8 bindings for async DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=39145

Attachment 57443: patch: fix the world context
https://bugs.webkit.org/attachment.cgi?id=57443&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
> WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp:55
>  +	  v8::Handle<v8::Context> v8Context =
toV8Context(m_scriptExecutionContext.get(),
WorldContextHandle(UseCurrentWorld));
> I'm not sure the "WorldContextHandle(UseCurrentWorld)" part is right.  Is
there other code that uses this pattern?

Turns out Adam was right. We should save the context in which the callback is
created and run the callback in that context, instead of the context in which
handleEvent() is called.


More information about the webkit-reviews mailing list