[webkit-reviews] review requested: [Bug 39928] Add a convenient helper getter for Frame* to RenderObject : [Attachment 57434] patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 30 22:23:56 PDT 2010
Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked for review:
Bug 39928: Add a convenient helper getter for Frame* to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=39928
Attachment 57434: patch v2
https://bugs.webkit.org/attachment.cgi?id=57434&action=review
------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
(In reply to comment #6)
> (From update of attachment 57429 [details])
> > - Frame* frame = document()->frame();
> > + Frame* frame = frame();
>
> I don't think this will work correctly, and I'm surprised it compiles
successfully. It needs to be:
> Frame* frame = this->frame();
Good catch, I've missed that one. Fixed.
More information about the webkit-reviews
mailing list