[webkit-reviews] review denied: [Bug 39680] [Qt] Expose the editing behavior setting in DRT to test all editing code paths : [Attachment 57403] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 30 11:16:49 PDT 2010


Eric Seidel <eric at webkit.org> has denied  review:
Bug 39680: [Qt] Expose the editing behavior setting in DRT to test all editing
code paths
https://bugs.webkit.org/show_bug.cgi?id=39680

Attachment 57403: proposed patch
https://bugs.webkit.org/attachment.cgi?id=57403&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We could even ASSERT_NOT_REACHED instead of loging.  That's probably better.

Yeah this should just ASSERT_NOT_REACHED.


More information about the webkit-reviews mailing list