[webkit-reviews] review granted: [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts. : [Attachment 57421] Patch for bug 35530.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Lyon Chen <liachen at rim.com>'s request
for review:
Bug 35530: Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro
conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Attachment 57421: Patch for bug 35530.
https://bugs.webkit.org/attachment.cgi?id=57421&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
These are fine except for the "E" prefix. They should be "DirectionForward" not
"EDirectionForward". I know the enums currently have names with "E" prefixes,
but it's not our standard coding style and pretty ugly!

I'm going to say r=me assuming this doesn't break the build, but I don't like
all that "E".