[webkit-reviews] review granted: [Bug 39916] Make more HTML DOM members private, especially constructors, third and final batch : [Attachment 57396] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 39916: Make more HTML DOM members private, especially constructors, third
and final batch
https://bugs.webkit.org/show_bug.cgi?id=39916

Attachment 57396: Patch
https://bugs.webkit.org/attachment.cgi?id=57396&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
JavaScriptCore/wtf/OwnArrayPtr.h:2
 +   *	Copyright (C) 2006, 2010 Apple Inc. All righs reserved.
Typo: All rights reserved.

WebCore/editing/DeleteButton.cpp:57
 +		return;
Is this a functional change, or just an optimization?  Since it seems quite
unrelated, it might make sense to do it in another patch. (We don't have any
DeleteButton tests do we?

WebCore/html/HTMLFrameSetElement.h:91
 +	OwnArrayPtr<Length> m_colLengths;
Where is OwnArrayPtr.h getting pulled in from?

WebCore/rendering/TextControlInnerElements.cpp:183
 +	    return;
Same question here about behavior change as the other defaultEventHandler
change.  This is in a few more places as well.

r=me. It seems like some of the EWS are not happy, so if you can divine their
complaints, that might be helpful before landing.