[webkit-reviews] review granted: [Bug 38156] many webkit-patch commands fail in a non-svn tracking git checkout : [Attachment 57369] Patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 38156: many webkit-patch commands fail in a non-svn tracking git checkout
https://bugs.webkit.org/show_bug.cgi?id=38156

Attachment 57369: Patch
https://bugs.webkit.org/attachment.cgi?id=57369&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Thanks for your responses.  A couple final comments for you to consider before
landing.  r=me

> +	   raise ScriptError(message='Can\'t find a branch to diff against. %s
branches do not exist.' % "and".join(remote_branch_refs))

Looks like this needs to be " and ".  You can also go back to double quotes now
if you want. :)

> +    def tearDown(self):
> +	   # Change back to a valid directory so that later calls to
os.getcwd() do not fail.
> +	   os.chdir(detect_scm_system(os.path.dirname(__file__)).checkout_root)


I would have returned to the original directory to be consistent with the
philosophy
of tests leaving no trace behind.