[webkit-reviews] review denied: [Bug 38233] Slow rendering w/multiple animated resizes : [Attachment 57367] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 38233: Slow rendering w/multiple animated resizes
https://bugs.webkit.org/show_bug.cgi?id=38233

Attachment 57367: Patch
https://bugs.webkit.org/attachment.cgi?id=57367&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
There are two problems i have with this patch 
* This optimisation also exists for scaled background-images, but i think has
(effectively) a duplicate of the code.
* I think the cut off logic is bad -- We shouldn't be looking at how long
between frames, we should be looking at how long it takes to do the paint.  I
think a "workable" approach maybe to trigger with something along the lines of:

   1. if shouldUseNormalQuality || (scale == FloatSize(1.0, 1.0))
      a. setScalingMode()
      b. paint normally
      c. return
   2. startTime = currentTime()
   3. paint normally
   4. endTime = currentTime();
   5. shouldUseNormalQuality = (endTime-startTime) > magicValue