[webkit-reviews] review denied: [Bug 39883] Adding tests to canvas.html performance test : [Attachment 57350] Patch to canvas.html
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 28 12:34:01 PDT 2010
David Levin <levin at chromium.org> has denied Sterling Swigart
<sswigart at google.com>'s request for review:
Bug 39883: Adding tests to canvas.html performance test
https://bugs.webkit.org/show_bug.cgi?id=39883
Attachment 57350: Patch to canvas.html
https://bugs.webkit.org/attachment.cgi?id=57350&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> +
> +function doStrokeTextTests() {
> + log("===== StrokeText Tests =====");
> + var strokeTextFunc = function(obj, str, x, y) { obj.strokeText(str, x,
y); };
> + for (var i = 1; i < 1001; i *= 10)
> + textTest(strokeTextFunc, i);
One last comment: It would be nice if these were written in a more async manner
to allow for any gc's to happen as done in other tests.
Example:
function doStrokeTextTests() {
log("===== StrokeText Tests =====");
doNextStrokeTextTest(1);
}
function doNextStrokeTextTest(var lineCount) {
var strokeTextFunc = function(canvas, str, x, y) { canvas.strokeText(str,
x, y); };
textTest(strokeTextFunc, i);
lineCount *= 10;
if (lineCount < 1001)
window.setTimeout(function () {
doNextStrokeTextTest(lineCount);
}, idleTimer);
else {
log("");
window.setTimeout(doFillTextTests, idleTimer);
}
}
More information about the webkit-reviews
mailing list