[webkit-reviews] review denied: [Bug 39646] Web Inspector: add Console API for retrieving memory stats : [Attachment 57320] now with updated test expectations!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 28 11:30:21 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 39646: Web Inspector: add Console API for retrieving memory stats
https://bugs.webkit.org/show_bug.cgi?id=39646

Attachment 57320: now with updated test expectations!
https://bugs.webkit.org/attachment.cgi?id=57320&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Oh, my bad. As ggaren pointed out, we need to make sure client code works fine
no matter whether dev extras / inspector are there or not. So we need to make
sure that console.memory object presents at all times. It may have no
properties in case instrumentation is not available.


More information about the webkit-reviews mailing list