[webkit-reviews] review denied: [Bug 39883] Adding tests to canvas.html performance test : [Attachment 57339] Patch to canvas.html
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 28 11:20:30 PDT 2010
David Levin <levin at chromium.org> has denied Sterling Swigart
<sswigart at google.com>'s request for review:
Bug 39883: Adding tests to canvas.html performance test
https://bugs.webkit.org/show_bug.cgi?id=39883
Attachment 57339: Patch to canvas.html
https://bugs.webkit.org/attachment.cgi?id=57339&action=review
------- Additional Comments from David Levin <levin at chromium.org>
In keeping with the C++ style, I would add spaces around the operators. For
example here: "500*j/numStrings"
WebKitSite/demos/canvas-perf/canvas.html:193
+ */
You should get rid of the commented out code.
WebKitSite/demos/canvas-perf/canvas.html:226
+ */
Ditto.
More information about the webkit-reviews
mailing list