[webkit-reviews] review granted: [Bug 39859] ScrollView::setFrameRect should not call contentsResized when there is a fixed layout size : [Attachment 57343] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 39859: ScrollView::setFrameRect should not call contentsResized when there
is a fixed layout size
https://bugs.webkit.org/show_bug.cgi?id=39859

Attachment 57343: Patch
https://bugs.webkit.org/attachment.cgi?id=57343&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index a63213f..7c99717 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,15 @@
> +2010-05-28  Adam Treat  <atreat at rim.com>
> +
> +	   Reviewed by Daniel Bates.
> +
> +	   Bug #293 and https://bugs.webkit.org/show_bug.cgi?id=39859
> +
> +	   Layout is not dependent upon ScrollView::frameRect when
useFixedLayout
> +	   is true.  No reason to set the needs layout flag in this case.
> +
> +	   * platform/ScrollView.cpp:
> +	   (WebCore::ScrollView::wheelEvent):

This change log disagrees with both the patch and the description since
ScrollView::wheelEven was not modified.

Looks sane to me.

r=me.