[webkit-reviews] review granted: [Bug 39882] openFile(...) in FIleSystemPOSIX does not call fileSystemRepresentation : [Attachment 57338] Patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 39882: openFile(...) in FIleSystemPOSIX does not call
fileSystemRepresentation
https://bugs.webkit.org/show_bug.cgi?id=39882

Attachment 57338: Patch.
https://bugs.webkit.org/attachment.cgi?id=57338&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!fsRep.data() || fsRep.data()[0] == '\0')
> +	   return invalidPlatformFileHandle;

I understand the check for null here, but:

   1) I suggest using the isNull function instead.
   2) Why the check for the empty string? I don't think there's a need to
optimize that case, and I expect open to give an error.

r=me